try to use "toJSON" method before converting named objects to string #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manniL
suggested changes
Sep 9, 2019
|
Thanks for PR. Please make a proper description of this change. An example of the edge case it is fixing, etc. Also would be a good idea to attempt fixing this issue at mainstream: https://github.com/Rich-Harris/devalue If it not works for everyone (a nuxt users requirement) we can then add patch here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nuxt uses devalue to pass vuex state from server- to client-side. And at the moment devalue converts simple objects to "json format" as is, key by key. But sometimes it is usefull to make some changes in a data before this conversion, "toJSON" method should be used for this.
For example, I create data models with default empty values on server-side, but due to some logic of my app the models were left as is, with default values, so there is no need to pass all keys of empty models to client-side, because I can create new empty models on client-side. So in this case the data model should have "toJSON" method, and devalue should call it. The method may look like this: